Update Renders FoamTex Differently

[Joelaff]

Not sure if this was intentional or not, so I thought I would point out that PHX build 31957 renders PhoenixFDFoamTex differently than PHX build 31862 (both from nightlies-- and Standalone for Linux (technically Maya-centos)) renders differently as well as the Max version). The foam is much brighter and/or broader.

I thought I would let you know in case that was not intentional, but we had to revert to the previous version because it wasn't matching how are scenes were set up.

Thanks.

[georgi.zhekov]

Hey,

Can you show us how it looks on your side before and after?

Thanks!

[Svetlin.Nikolov]

Aha, Georgi managed to reproduce it. This is because of a fix I did for an issue where using an ocean tex with Rate of Change = 0 did not render the foam tex at all.

The new results are the correct ones.

Cheers!

[Joelaff]

OK. But old scenes will render differently, which is less than ideal.

I have a couple more bugs for you to hunt down. Let me see if I can dig up the correct scenes. Will post a new thread with the correct context.

[Svetlin.Nikolov]

Yup, usually for changes of behavior I do conversion for old scenes so they keep their behavior, but not for bugfixes like that. Since it prevented incorrect calculations, the formula is now different, so there is no GUI setting that would be able to mimic the old behavior in the new version. Is it an option to use the old build?

[Joelaff]

I am using the old build until this project is done, yes. I guess in a perfect world each node would record what version was used last time an adjustment was made and then use the code associated with that version, but I get it.. maintenance would be a nightmare, more branching would slow things down (esp with all these spectre-esque CPU microcode "updates").

If the change is intentional and for good reason, I have no issues with that. It just caught me off guard since I tried to get by with using a different build on linux than on Windows (which I know is never a good idea, but when it is 5AM and you are trying to just get the thing done it seems like one).

[Svetlin.Nikolov]

Sorry about that